[Fusion] Check if type can be resolved when selecting best matching subgraph #8497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… best matching subgraph
1 task
|
Hey Dani :) Thanks for the contribution! The change seems sensible to me, but it appears some tests in Also it would be nice, if you could add a test like this that showcases the effect of your fix. |
src/HotChocolate/Fusion/src/Core/Planning/QueryPlannerHelpers.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Fusion/src/Core/Planning/QueryPlannerHelpers.cs
Outdated
Show resolved
Hide resolved
tobias-tengler
approved these changes
Aug 10, 2025
tobias-tengler
changed the title
michaelstaib
merged commit 35bcd91
into
ChilliCream:main-version-15
103 of 105 checks passed
This was referenced Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into the same issue as #6727
Feel free to take a look, feedback is welcome! Thanks!
We check if the schema contains the necessary resolver for a type when selecting the best matching subgraph